From 375315d0f4d6bd31a7d6eb0e9f98d32d3e76aa2f Mon Sep 17 00:00:00 2001
From: agp8x <bitbucket@clemensklug.de>
Date: Thu, 7 Aug 2014 11:50:12 +0200
Subject: [PATCH] added modes to mkdir's, some todos

---
 Logger.py           | 1 +
 all.py              | 6 +++---
 logs/all.log        | 1 -
 logs/exceptions.xml | 1 -
 move.py             | 4 +++-
 5 files changed, 7 insertions(+), 6 deletions(-)
 delete mode 100644 logs/all.log
 delete mode 100644 logs/exceptions.xml

diff --git a/Logger.py b/Logger.py
index eb60a39..1bcbc30 100644
--- a/Logger.py
+++ b/Logger.py
@@ -36,6 +36,7 @@ class Logger(object):
 	# common function to write value to file #
 	##########################################
 	def write_value(self,value,sensor):
+		# TODO: catch IOError
 		valuename=self.records+"/"+self.names[sensor]+"_"+preptime()
 		valuelog=open(valuename,'a')
 		valuelog.write(str(value) + ';' + str(int(time.time())) +"\n")
diff --git a/all.py b/all.py
index f7ab815..04b5955 100644
--- a/all.py
+++ b/all.py
@@ -24,7 +24,7 @@ import settings
 def check_dirs_and_files():
 	# log
 	if not os.path.exists(settings.logs):
-		os.mkdir(settings.logs)
+		os.mkdir(settings.logs, 0000755)
 	if not os.path.exists(settings.logname):
 		open(settings.logname, 'w').close()
 	if not os.path.exists(settings.exceptionlog):
@@ -33,10 +33,10 @@ def check_dirs_and_files():
 		file.close()
 	# lock
 	if not os.path.exists(settings.locks):
-		os.mkdir(settings.locks)
+		os.mkdir(settings.locks, 0000755)
 	# records
 	if not os.path.exists(settings.records):
-		os.mkdir(settings.records)
+		os.mkdir(settings.records, 0000755)
 
 if __name__ == "__main__":
 	check_dirs_and_files()
diff --git a/logs/all.log b/logs/all.log
deleted file mode 100644
index 471847e..0000000
--- a/logs/all.log
+++ /dev/null
@@ -1 +0,0 @@
-an Exception happen during connection @Tue Jul 22 12:39:27 2014
diff --git a/logs/exceptions.xml b/logs/exceptions.xml
deleted file mode 100644
index 59003a9..0000000
--- a/logs/exceptions.xml
+++ /dev/null
@@ -1 +0,0 @@
-<exceptions></exceptions>
\ No newline at end of file
diff --git a/move.py b/move.py
index 26f461f..c21963c 100644
--- a/move.py
+++ b/move.py
@@ -5,6 +5,8 @@ import time
 import os
 from timeFunctions import *
 
+# TODO: path from settings
+
 checkfile='locks/records_moved'
 
 if not os.path.exists(checkfile):
@@ -30,7 +32,7 @@ else:
 		log.flush()
 		if not os.path.exists("arch"):
 			os.mkdir("arch")
-		os.system("./move.sh "+preptime())
+		os.system("./move.sh "+preptime())	# TODO: replace me with: https://docs.python.org/2/library/shutil.html#module-shutil
 		check.close()
 		check=open(checkfile,'w')
 		check.write(str(time.time()))